stevedlawrence commented on a change in pull request #38: Move 
built-in-formats.xsd to test and the backwards compatibility added for it
URL: https://github.com/apache/incubator-daffodil/pull/38#discussion_r167231077
 
 

 ##########
 File path: 
daffodil-cli/src/test/scala/org/apache/daffodil/saving/TestCLISaveParser.scala
 ##########
 @@ -50,7 +48,8 @@ class TestCLISaveParser {
     val shell = Util.start("")
 
     try {
-      String.format("%s save-parser -s %s -r matrix %s", Util.binPath, 
testSchemaFile, savedParserFile.getName()) !
 
 Review comment:
   These tests used the scala ``!`` to execute the command to save a parser, 
then used expected to run the command to use the saved parser. We only 
configure Expect to have the daffodil-lib/src/test stuff on the classpath, so 
this wouldn't be able to find built-in-formats.xsd. So instead use Expect to 
execute this command so it's gets the right classpath info.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to