stevedlawrence commented on a change in pull request #48: All SDW have WarnIDs 
to support suppression of warnings.
URL: https://github.com/apache/incubator-daffodil/pull/48#discussion_r171226536
 
 

 ##########
 File path: 
daffodil-lib/src/main/scala/org/apache/daffodil/exceptions/ThrowsSDE.scala
 ##########
 @@ -82,32 +83,29 @@ trait ThrowsSDE {
 trait SavesErrorsAndWarnings {
 
   def SDE(id: String, args: Any*): Nothing
 
 Review comment:
   We should probably also have a similar ErrorID for SDE's. That would be the 
first step towards adding support for something like JALoP or various other 
auditing mechanisms. Not worth doing as part of this since there's no use for 
those ID's like there are for warn IDs, but something to think about for the 
future. Could be a good task for a new developer.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to