mbeckerle commented on a change in pull request #49: Daffodil 1907 non dfdl 
annotation
URL: https://github.com/apache/incubator-daffodil/pull/49#discussion_r171432721
 
 

 ##########
 File path: 
daffodil-lib/src/main/scala/org/apache/daffodil/xml/DaffodilXMLLoader.scala
 ##########
 @@ -518,7 +518,14 @@ class DaffodilXMLLoader(val errorHandler: 
org.xml.sax.ErrorHandler) {
   def load(source: DaffodilSchemaSource): scala.xml.Node = {
     var xercesNode: Node = null
     if (doValidation) {
-      xercesNode = xercesAdapter.load(source.newInputSource()) // validates
+      //
+      // We need a try/catch here as error recording needs to
 
 Review comment:
   Remove comment. Try/catch is now in caller of this. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to