[
https://issues.apache.org/jira/browse/DAFFODIL-1473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Beckerle resolved DAFFODIL-1473.
----------------------------------------
Resolution: Fixed
Assignee: Dave Thompson (was: Michael Beckerle)
Fixed in hash 6ad629d19b9c53db117155ed4f99ec565a07e274
Evidence of this fix is a little hard to isolate. Many tests that used to
require the
validateDFDLSchemas=true flag do not any more. (look in
daffodil-test/src/test/scala for the changed files associated with this commit.)
Largely this was a code cleanup which gets the redundant validation code out of
SchemaSet and into DFDLSchemaFile where it should be centralized.
> DFDL Schema Validation not happening properly
> ---------------------------------------------
>
> Key: DAFFODIL-1473
> URL: https://issues.apache.org/jira/browse/DAFFODIL-1473
> Project: Daffodil
> Issue Type: Bug
> Components: Front End, General
> Affects Versions: 2.0.0
> Reporter: Michael Beckerle
> Assignee: Dave Thompson
> Priority: Major
> Fix For: 2.2.0
>
>
> I discovered that the natural xerces load time validation that is supposed to
> happen when DFDL schemas are loaded, is not happening.
> There seems to be code for doing a whole separate load pass just to validate
> rather than doing it at load time. This might be a holdover from when we were
> using the "constructing parser" for XML for more things, rather than Xerces.
> Not sure.
> All I know is that in DFDLSchemaFile.scala, there is no call to
> loader.setValidation(...) so those loads don't validate, and that causes many
> syntactic problems to go undetected.
> However, I don't want to fix this right now, because lots of tests break. We
> should fix this one little thing and fix up the tests that break at that
> point in one commit.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
