stevedlawrence commented on a change in pull request #61: Preliminary Review -
Base64 layering runs first parsing unit test.
URL: https://github.com/apache/incubator-daffodil/pull/61#discussion_r183048026
##########
File path:
daffodil-io/src/test/scala/org/apache/daffodil/layers/TestBase64.scala
##########
@@ -36,16 +36,25 @@ import org.apache.daffodil.exceptions.Assert
class TestBase64 {
Assert.usage(scala.util.Properties.isJavaAtLeast("1.8"))
- val text = """Man is distinguished, not only by his reason, but by this
singular passion from
-other animals, which is a lust of the mind, that by a perseverance of delight
-in the continued and indefatigable generation of knowledge, exceeds the short
-vehemence of any carnal pleasure.""".replace("\n", " ")
-
- val b64Text =
"""TWFuIGlzIGRpc3Rpbmd1aXNoZWQsIG5vdCBvbmx5IGJ5IGhpcyByZWFzb24sIGJ1dCBieSB0aGlz
-IHNpbmd1bGFyIHBhc3Npb24gZnJvbSBvdGhlciBhbmltYWxzLCB3aGljaCBpcyBhIGx1c3Qgb2Yg
-dGhlIG1pbmQsIHRoYXQgYnkgYSBwZXJzZXZlcmFuY2Ugb2YgZGVsaWdodCBpbiB0aGUgY29udGlu
-dWVkIGFuZCBpbmRlZmF0aWdhYmxlIGdlbmVyYXRpb24gb2Yga25vd2xlZGdlLCBleGNlZWRzIHRo
-ZSBzaG9ydCB2ZWhlbWVuY2Ugb2YgYW55IGNhcm5hbCBwbGVhc3VyZS4=""".replace("\n",
"\r\n")
+ //
+ // This is from Don Quixote which is entirely public domain
+ //
Review comment:
According to ASF, public domain attribution must be done in the LICENSE
file. Here's an example of Apache Hivemail (incubating) attributing public
domain code:
https://github.com/apache/incubator-hivemall/blob/master/LICENSE#L270-L279
This isn't code, but I assume attribution is still required regardless. Not
sure of the correct format for a quote attribution or if there is an exception
for this type of public domain stuff, which is clearly different from code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
