mbeckerle commented on a change in pull request #61: Base64, gzip, and line-folding layering URL: https://github.com/apache/incubator-daffodil/pull/61#discussion_r185888623
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/LayeredSequenceParser.scala ########## @@ -0,0 +1,55 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.daffodil.processors.parsers + +import org.apache.daffodil.processors.TermRuntimeData +import org.apache.daffodil.processors.LayerTransformerEv +import org.apache.daffodil.io.ByteBufferDataInputStream + +class LayeredSequenceParser(rd: TermRuntimeData, + layerTransformerEv: LayerTransformerEv, + bodyParser: Parser) + extends SequenceCombinatorParser(rd, bodyParser) { Review comment: So both the parser and unparser both call super.parse(state) or super.unparse(state) so as to reuse the guts of the parser. Once the parser and unparser for Sequence are revised though, this may no longer make sense. There is a lot of code reuse for unparser especially here. No matter what happens when Sequence is reimplemented this code reuse will need to be preserved. The answer to your question is no however, the properties like dfdl:separatorSuppressionPolicy will not apply, as the body parser for these cannot have an array (now enforced), and can be only one term, and the grammar doesn't put down separator grammar terms around it. So it will not have any "sequence-like" behavior associated with separators. (Unless of course the single body itself IS a sequence, but then the properties are its own, not those of the layered sequence.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
