rmw42 opened a new pull request #72: Fix modulus problem with ULong URL: https://github.com/apache/incubator-daffodil/pull/72 The ULong code incurrectly calculates the modulus (remainder) of values and x%y can have values in the range 0<=val<2y instead of 0<=val<y, due to the way unsigned arithmetic is performed using signed primitives. This commit fixes the underlying problem and adds test cases to check the behaviour is correct with both small (<2^63) and large (>=2^63) unsigned longs. DAFFODIL-1714
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
