stevedlawrence commented on a change in pull request #75: Daffodil 1738 zoned decimal URL: https://github.com/apache/incubator-daffodil/pull/75#discussion_r195414933
########## File path: daffodil-test/src/test/scala-debug/org/apache/daffodil/section13/zoned/TestZonedDebug.scala ########## @@ -0,0 +1,39 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.daffodil.section13.zoned + +import org.apache.daffodil.tdml.Runner +import org.junit.AfterClass +import org.junit.Test + +object TestZoned { + val testDir = "/org/apache/daffodil/section13/zoned/" + lazy val runner = Runner(testDir, "zoned.tdml") + + @AfterClass def shutdown(): Unit = { + runner.reset + } + +} + +class TestZoned { + import TestZoned._ + + @Test def testZonedTandemModified02(): Unit = { runner.runOneTest("ZonedTandemModified02") } + @Test def testZonedTandemModified05(): Unit = { runner.runOneTest("ZonedTandemModified05") } Review comment: Can you create a bug and mention it in a comment? Also, we confirmed that this isn't a bug with the zoned implementation, but is actually a bug in how € is converted to bytes, right? It might be worth creating a really simple test case that doesn't involve any zoned stuff just to ensure there isn't something else funky going on. Maybe something that expects a single hex byte and show that € is converted to two bytes instead of one due to UTF-8. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
