mbeckerle commented on a change in pull request #77: Modifications to IO layer
to support streaming input data
URL: https://github.com/apache/incubator-daffodil/pull/77#discussion_r201035109
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/compiler/Compiler.scala
##########
@@ -255,7 +255,7 @@ class Compiler(var validateDFDLSchemas: Boolean = true)
def reload(savedParser: File) = reload(new
FileInputStream(savedParser).getChannel())
- def reload(savedParser: DFDL.Input): DFDL.DataProcessor = {
+ def reload(savedParser: java.nio.channels.ReadableByteChannel):
DFDL.DataProcessor = {
Review comment:
Should this be deprecated, i.e., the new real API wants InputStream now
right? I think the only reasons for wanting a Channel were to allow memory
mapped I/O, which was a false requirement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
