stevedlawrence commented on a change in pull request #83: Adding value of 'bcd' to binaryCalendarRep URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203363509
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesDateTime1.scala ########## @@ -180,6 +201,8 @@ case class ConvertBinaryCalendarSecMilliParser( override lazy val runtimeDependencies = Nil + def toBigDecimal(num: Array[Byte], scale: Int): JBigDecimal = DecimalUtils.bcdToBigDecimal(num, scale) Review comment: The ConvertBinaryCalendarSecMilliParser is doing conversions with bcd? Is that correct? Looks like it's never used, can it be removed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
