mbeckerle commented on a change in pull request #83: Adding value of 'bcd' to
binaryCalendarRep
URL: https://github.com/apache/incubator-daffodil/pull/83#discussion_r203417717
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/PrimitivesDateTime1.scala
##########
@@ -17,23 +17,34 @@
package org.apache.daffodil.processors.parsers
+import java.lang.{ Long => JLong }
+import java.math.{ BigDecimal => JBigDecimal, BigInteger => JBigInteger }
import java.text.ParsePosition
import com.ibm.icu.text.SimpleDateFormat
import com.ibm.icu.util.Calendar
import com.ibm.icu.util.ULocale
import org.apache.daffodil.exceptions.Assert
+
import org.apache.daffodil.calendar.DFDLDateTime
import org.apache.daffodil.calendar.DFDLTime
import org.apache.daffodil.calendar.DFDLDate
import org.apache.daffodil.processors.CalendarEv
import org.apache.daffodil.processors.CalendarLanguageEv
import org.apache.daffodil.processors.ElementRuntimeData
+import org.apache.daffodil.processors.Evaluatable
+import org.apache.daffodil.processors.FieldDFAParseEv
+import org.apache.daffodil.processors.ParseOrUnparseState
import org.apache.daffodil.processors.Processor
+import org.apache.daffodil.processors.dfa.TextDelimitedParserBase
import org.apache.daffodil.schema.annotation.props.gen.BinaryCalendarRep
+import org.apache.daffodil.schema.annotation.props.gen.LengthUnits
+import org.apache.daffodil.util.DecimalUtils
+
+trait ConvertTextCalendarProcessorBase extends Processor {
+
+ override val context: ElementRuntimeData
+ val pattern: String
Review comment:
Scala style: Use def for a unimplemented thing, not val.
def can be overridden by val or lazy val or def.
Does this pattern need to be public? can it be protected?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
