stevedlawrence commented on a change in pull request #86: Adding value of 'bcd'
to binaryCalendarRep
URL: https://github.com/apache/incubator-daffodil/pull/86#discussion_r205427929
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/primitives/PrimitivesDateTime.scala
##########
@@ -167,28 +193,38 @@ case class ConvertTextDatePrim(e: ElementBase) extends
ConvertTextCalendarPrimBa
protected override val prettyType = "Date"
protected override val infosetPattern = "uuuu-MM-ddxxx"
protected override val implicitPattern = "uuuu-MM-dd"
- protected override val validFormatCharacters = "dDeEFGMuwWyXxYzZ".toSeq
+ protected override val validFormatCharacters =
+ if (e.representation == Representation.Binary) {
+ "dDeFMuwWyXxYZ".toSeq
Review comment:
I think the x, X, and Z charactres allow non numeric digits like plus/minus
signs and colons. I think they shouldn't be allowed in these patterns when rep
is binary.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
