mbeckerle commented on a change in pull request #88: Daffodil 1919 separators
URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r206559450
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/TermGrammarMixin.scala
##########
@@ -128,46 +96,31 @@ trait TermGrammarMixin
nearestEnclosingSequence
}
- private def hasES = nearestEnclosingSequence != None
- private def ignoreES = inChoiceBeforeNearestEnclosingSequence == true
+ protected final def hasES = nearestEnclosingSequence != None
+ protected final def ignoreES = inChoiceBeforeNearestEnclosingSequence == true
- private lazy val separatorItself = prod("separator", !ignoreES && hasES) {
- //
- // TODO: (JIRA DFDL-1400) The separators may be in a different encoding
than the terms
- // that they separate.
- //
- // So we must allow for a change of encoding (which may also imply a change
- // of bit order)
- //
- // However, this isn't the same as just plopping down a bitOrderChange ~
encodingChange, since
- // those examine prior peer, and what we want to scrutinize is the prior
term being separated.
- //
- delimMTA ~ Separator(es, self)
- }
+ // private lazy val sepRule = separatorItself
Review comment:
delete commented code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
