mbeckerle commented on a change in pull request #88: Daffodil 1919 separators URL: https://github.com/apache/incubator-daffodil/pull/88#discussion_r206590774
########## File path: daffodil-tdml/src/main/scala/org/apache/daffodil/tdml/TDMLRunner.scala ########## @@ -115,6 +115,13 @@ case object OnePassRoundTrip extends RoundTrip */ case object TwoPassRoundTrip extends RoundTrip +/** + * Unparse doesn't produce original data, parsing it doesn't produce the + * same infoset, but an equivalent infoset which if unparsed, reproduces + * the first unparse output. Review comment: Enhance comment pointing out how this can mask errors. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
