mbeckerle opened a new pull request #94: Daffodil 1919 separators2 URL: https://github.com/apache/incubator-daffodil/pull/94 (Alas... I made a mistake and rebased my daffodil-1919-separators branch onto latest master. Having done that I cannot push it to the prior review anymore without --force, so I am putting up this additional review so as to have the prior review still available.) This is a review for the sequence groups and separators changes. All changes suggested in review comments on PR 88 https://github.com/apache/incubator-daffodil/pull/88 have been incorporated with the exception of the Vectorization of the runtime, which I will submit as its own PR after this one. Status: sbt test - all tests pass, sbt it:test all tests pass. All DFDLSchemas - on for-daffodil-2.2.0 branches I have created, they all work with minor changes (scala 2.12, 2.2.0-SNAPSHOT, eliminate warnings, increase maxOccursCount, update some TDML tests to stipulate twoPass, etc.) All FOUO schemas - on for-daffodil-2.2.0 branches I have created, they all work with similar minor changes. One exception worth study is uscg_ucop_lh which requires the TDML tests to be threePass in order to test. So this may be masking errors, or it may be that the XML really just isn't very much like what the data unparses to.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
