mbeckerle commented on a change in pull request #100: Moved pushDiscriminator
to fix separators bug.
URL: https://github.com/apache/incubator-daffodil/pull/100#discussion_r210124141
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/SeparatedSequenceParsers.scala
##########
@@ -299,6 +299,18 @@ final class OrderedSeparatedSequenceParser(
val bitPosBeforeSeparator = pstate.bitPos0b
+ pstate.pushDiscriminator
Review comment:
The pushD gives a clean false dis criminaltor at start. The only way that
disc is set is when we parse The element Itself - which happens after the infix
sep as you pointed out - so there can be a disc set after a postfix sep fails
but not prefix or infix.
I am considering moving the push/ pop into the base class method so it will
be centralized and not even an issue here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
