stevedlawrence commented on a change in pull request #129: Cross Testing
Capability with IBM DFDL
URL: https://github.com/apache/incubator-daffodil/pull/129#discussion_r229674996
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/TermEncodingMixin.scala
##########
@@ -34,12 +34,12 @@ trait TermEncodingMixin extends KnownEncodingMixin { self:
Term =>
requiredEvaluations(encodingInfo.preSerialization)
requiredEvaluations(checkTextBidi)
- private lazy val optionTextBiDi = findPropertyOption("textBiDi")
+ private lazy val optionTextBiDi = findPropertyOption("textBidi")
private def checkTextBidi = {
this.subset(
- !optionTextBiDi.isDefined || (optionTextBiDi.isDefined && (textBiDi eq
YesNo.No)),
- "Property value textBiDi='yes' is not supported.")
+ !optionTextBiDi.isDefined || (optionTextBiDi.isDefined && (textBidi eq
YesNo.No)),
+ "Property value textBidi='yes' is not supported.")
Review comment:
Is there a potentially backwards compatibility issues here? If someone
didn't use our DFDLGeneralFormat.dfdl.xsd then they would have needed to
specified "textBiDi" in their dfdl:format, which won't work anymore. Is it
worth falling back to textBiDi if textBidi doesn't exist and throwing a
deprecation warning? It's so minor and easy to fix that maybe it's not worth it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
