mbeckerle commented on a change in pull request #136: Changing to ignore
attributeFormDefault
URL: https://github.com/apache/incubator-daffodil/pull/136#discussion_r233493979
##########
File path:
daffodil-test-ibm1/src/test/scala-debug/org/apache/daffodil/IBMTests2.scala
##########
@@ -44,10 +44,8 @@ class IBMTestsThatThrow {
lazy val runner1 = new DFDLTestSuite(Misc.getRequiredResource(tdml1))
lazy val runner2 = new DFDLTestSuite(Misc.getRequiredResource(tdml2))
- @Test def test_scoping_define_format_8_04() {
runner1.runOneTest("scoping_define_format_8_04") } //DFDL-565 -
attributeFormDefault='qualified'
-
- @Test def test_scoping_default_format_8_01() {
runner1.runOneTest("scoping_default_format_8_01") } // DFDL-565
attributeFormDefault='qualified'
- @Test def test_scoping_define_format_8_01() {
runner1.runOneTest("scoping_define_format_8_01") } // DFDL-565
attributeFormDefault='qualified'
+ @Test def test_scoping_default_format_8_01() {
runner1.runOneTest("scoping_default_format_8_01") } // Attribute
"encodingErrorPolicy" was already specified - bug in IBM test
+ @Test def test_scoping_define_format_8_01() {
runner1.runOneTest("scoping_define_format_8_01") } // Attribute
"encodingErrorPolicy" was already specified - bug in IBM test
Review comment:
This feels like our mistake adding the duplicate encodingErrorPolicy
property. That is, this property encodingErrorPolicy, is relatively new.
Probably hadn't even been invented when we first got a bunch of preliminary
DFDL tests from IBM for incorporation into Daffodil years ago. So we
subsequently added this to keep the tests working, once the new property was
added to Daffodil, and required. I think adding it twice was just a mistake we
made.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
