mbeckerle commented on a change in pull request #138: Adding error when
dfdl:initiator is "%"
URL: https://github.com/apache/incubator-daffodil/pull/138#discussion_r233655828
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala
##########
@@ -186,6 +186,9 @@ trait DelimitedRuntimeValuedPropertiesMixin
val qn = this.qNameForProperty("initiator")
val typeIfStaticallyKnown = NodeInfo.String
val typeIfRuntimeKnown = NodeInfo.NonEmptyString
+ if (initiatorRaw.value == "%") {
+ SDE("Invalid dfdl:initiator. \"%\" cannot be a dfdl:initiator.")
Review comment:
Suggest improve message not to just say it's wrong, but suggest the user
meant "%%", and remind them that % introduces DFDL entities and so must be
self-escaped if you want to literally express a single % character.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
