stevedlawrence commented on a change in pull request #136: Changing to ignore 
attributeFormDefault
URL: https://github.com/apache/incubator-daffodil/pull/136#discussion_r233844924
 
 

 ##########
 File path: 
daffodil-test-ibm1/src/test/scala-debug/org/apache/daffodil/IBMTests2.scala
 ##########
 @@ -44,10 +44,8 @@ class IBMTestsThatThrow {
   lazy val runner1 = new DFDLTestSuite(Misc.getRequiredResource(tdml1))
   lazy val runner2 = new DFDLTestSuite(Misc.getRequiredResource(tdml2))
 
-  @Test def test_scoping_define_format_8_04() { 
runner1.runOneTest("scoping_define_format_8_04") } //DFDL-565 - 
attributeFormDefault='qualified'
-
-  @Test def test_scoping_default_format_8_01() { 
runner1.runOneTest("scoping_default_format_8_01") } // DFDL-565 
attributeFormDefault='qualified'
-  @Test def test_scoping_define_format_8_01() { 
runner1.runOneTest("scoping_define_format_8_01") } // DFDL-565 
attributeFormDefault='qualified'
+  @Test def test_scoping_default_format_8_01() { 
runner1.runOneTest("scoping_default_format_8_01") } // Attribute 
"encodingErrorPolicy" was already specified - bug in IBM test
+  @Test def test_scoping_define_format_8_01() { 
runner1.runOneTest("scoping_define_format_8_01") } // Attribute 
"encodingErrorPolicy" was already specified - bug in IBM test
 
 Review comment:
   [DAFFODIL-1616](https://issues.apache.org/jira/browse/DAFFODIL-1616) is the 
bug to fix the issue related to textOutputMinLength, which Mike is working on. 
If the tests work with that property added, it seems fine to me to modify the 
tests and add the property, and eventually that property will just be ignored 
when Mike's fix is in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to