efinnegan commented on a change in pull request #139: Updating to set encoding
of CLI output to UTF-8
URL: https://github.com/apache/incubator-daffodil/pull/139#discussion_r234360650
##########
File path: daffodil-cli/src/main/scala/org/apache/daffodil/Main.scala
##########
@@ -845,7 +845,7 @@ object Main extends Logging {
case Some("-") | None => System.out
case Some(file) => new FileOutputStream(file)
}
- val writer = new BufferedWriter(new OutputStreamWriter(output))
+ val writer = new BufferedWriter(new OutputStreamWriter(output,
"UTF-8"))
Review comment:
I tested this by changing my settings to use
DAFFODIL_JAVA_OPTS="-Dfile.encoding=ASCII". The "É" in my output showed as a
"?" without this change. I'm not sure if there is a test we can add to show
this though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
