stevedlawrence commented on a change in pull request #143: Support
dfdl:length="prefixed"
URL: https://github.com/apache/incubator-daffodil/pull/143#discussion_r239893826
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/BinaryNumberTraits.scala
##########
@@ -50,3 +56,63 @@ trait HasRuntimeExplicitLength {
nBytes * toBits
}
}
+
+
+trait PrefixedLengthParserMixin {
+
+ def prefixedLengthParser: Parser
+ def prefixedLengthERD: ElementRuntimeData
+ def lengthUnits: LengthUnits
+ def prefixedLengthAdjustmentInUnits: Long
Review comment:
The spec says:
> It is a schema definition error if the xs:simpleType [referenced by
prefixLengthType] specifies any of:
> ...
> * dfdl:lengthKind 'explicit' where length is an expression
> ...
So I'm not sure it will ever need to be evaluatable. THe prefix length is
always known at schema compile time. Except for the case in nested prefixes,
but I think that wil result in lots more changes. I'm not sure how that would
work, but I'm not sure an evaluatable will be right way to do it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services