stevedlawrence opened a new pull request #146: Fix hexBinary with non-byte lengths or non-byte boundaries URL: https://github.com/apache/incubator-daffodil/pull/146 - Elements with xs:hexBinary type no longer take into account byte order when reading bytes. Previously, Daffodil used an algorithm where the hex binary was essentially the hex binary representation of the non-negative integer of the same bit length. This is wrong and not compatible with the specification (for example, the little endian hex binary how the bytes in the reverse order). This changes Daffodil so it now reads eight bits at time and converts each eight bits to hex binary digits. The eights bits are read according to the bitOrder, and if less than eight bits are available, zero bit padding is applied to either the left or right according to the bit order to reach a full byte. - This is a non-backwards compatible change, but makes Daffodil now compatible with the DFDL specification. Any hexBinary element that either had little endian byte order or were non-byte size lengths will now have different output. DAFFODIL-2019
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
