mbeckerle commented on a change in pull request #150: Removed use of
ThreadLocal for DFA Register Pool.
URL: https://github.com/apache/incubator-daffodil/pull/150#discussion_r240830848
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/dfa/TextDelimitedParser.scala
##########
@@ -29,22 +29,22 @@ import org.apache.daffodil.equality._
import org.apache.daffodil.util.MaybeChar
import org.apache.daffodil.processors.DelimiterIterator
import org.apache.daffodil.io.FormatInfo
+import org.apache.daffodil.processors.parsers.PState
-abstract class TextDelimitedParserBase(
- override val justificationTrim: TextJustificationType.Type,
+abstract class TextDelimitedParserBase(override val justificationTrim:
TextJustificationType.Type,
override val parsingPadChar: MaybeChar,
override val context: TermRuntimeData)
extends DFAParser with PaddingRuntimeMixin {
private lazy val padCharInfo = if (parsingPadChar.isDefined)
parsingPadChar.toString else "NONE"
lazy val info: String = "justification='" + justificationTrim + "',
padChar='" + padCharInfo + "'"
- final def parse(finfo: FormatInfo, input: DataInputStream, field: DFAField,
delimIter: DelimiterIterator, isDelimRequired: Boolean): Maybe[ParseResult] = {
+ final def parse(finfo: PState, input: DataInputStream, field: DFAField,
delimIter: DelimiterIterator, isDelimRequired: Boolean): Maybe[ParseResult] = {
Review comment:
change name from finfo to 'state'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
