jadams-tresys commented on a change in pull request #155: Don't require
binaryNumberRep for hexBinary
URL: https://github.com/apache/incubator-daffodil/pull/155#discussion_r241848010
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ElementBase.scala
##########
@@ -653,29 +653,29 @@ trait ElementBase
}
}
+ private lazy val optionBinaryNubmerRep =
findPropertyOption("binaryNumberRep")
+ /* All binary number representations other than "binary" are of some packed
format */
+ private lazy val isPackedBinaryNumber: Boolean =
optionBinaryNumberRep.isDefined && (binaryNumberRep != BinaryNumberRep.Binary)
Review comment:
I have updated the code to not rely on whether or not binaryNumberRep is
defined.
I have also tried to tidy up the areas with all the pipes, but I still
prefer the use of pipes instead of having several more case statements that
evaluate to the same thing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
