[ 
https://issues.apache.org/jira/browse/DAFFODIL-1952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16721688#comment-16721688
 ] 

Josh Adams commented on DAFFODIL-1952:
--------------------------------------

Took a look at this one and as far as I can tell the ??? is never reached in 
the code.  I replaced it with an Assert.impossible() and had 0 test failures.  
I wasn't sure if I should open up a pull request for this change as I still 
don't really understand why it can never be reached.  It just seems like we are 
never calling getSkipBits on a complex element.

> Fix ??? in code - SpecifiedLength2.scala
> ----------------------------------------
>
>                 Key: DAFFODIL-1952
>                 URL: https://issues.apache.org/jira/browse/DAFFODIL-1952
>             Project: Daffodil
>          Issue Type: Bug
>          Components: Back End, Clean Ups
>    Affects Versions: 2.1.0
>            Reporter: Michael Beckerle
>            Priority: Major
>
> Found a ??? (Unimplemented stub for scala) in file SpecifiedLength2.scala.
> This is clearly just an oversight and should be implemented or replaced with 
> an appropriate SDE/PE/UE, or Assert. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to