jadams-tresys commented on a change in pull request #164: Avoid
CircularDefinition error for appinfo
URL: https://github.com/apache/incubator-daffodil/pull/164#discussion_r247627076
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/ModelGroup.scala
##########
@@ -153,14 +153,7 @@ abstract class ModelGroup
final override def isRequiredOrComputed = true
final override def isArray = false
- private def prettyIndex = LV('prettyIndex) {
- myPeers.map { peers =>
- {
- if (peers.length == 1) "" // no index expression if we are the only one
- else "[" + (peers.indexOf(this) + 1) + "]" // 1-based indexing in
XML/XSD
- }
- }.getOrElse("")
- }.value
+ private def prettyIndex = "[" + index + "]" // 1-based indexing in XML/XSD
Review comment:
Fixed this issue by having it look for seq[1] instead of just seq.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
