mbeckerle commented on a change in pull request #163: Fix performance issues
with recent hexBinary changes
URL: https://github.com/apache/incubator-daffodil/pull/163#discussion_r247676525
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/dsom/RuntimePropertyMixins.scala
##########
@@ -524,34 +536,44 @@ trait ElementRuntimeValuedPropertiesMixin
ReferencedElementInfos.None
private def localElementPropertyReferencedElements(f: F) = {
Review comment:
I'm going to submit a ticket about internal code doc improvement needed for
this f: F parameter.
I have a hard time understanding this code, but it is not due to your
changes. It's just lack of good identifiers, and lack of doc for some traits,
etc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
