stevedlawrence commented on a change in pull request #167: Daffodil 2051 tests
broken in windows
URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248674418
##########
File path:
daffodil-test-ibm1/src/test/resources/test-suite/tresys-contributed/AG.tdml
##########
@@ -24,9 +24,9 @@
<parserTestCase name="AG000" root="allZones" model="AG.dfdl.xsd"
description="Discriminated choices"
roundTrip="true">
- <document><![CDATA[1
-zone 1
-]]></document>
+ <document>
+ <documentPart type="text"
replaceDFDLEntities="true"><![CDATA[1%LF;zone 1%LF;]]></documentPart>
Review comment:
I imagine anything with a percent sign would break since that would look
like an invalid DFDL entitity? A quick grep shows about 65 lines that contain
"document" and a percent and don't already have replaceDFDLEntities set. So I'd
guess at least that many would need replaceDFDLEntities="false", which is
probably about the same amount that needed to be changed in this commit so I'm
not sure it would be all the different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
