mbeckerle commented on a change in pull request #167: Daffodil 2051 tests
broken in windows
URL: https://github.com/apache/incubator-daffodil/pull/167#discussion_r248491876
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section06/namespaces/namespaces.tdml
##########
@@ -167,8 +167,9 @@
<tdml:parserTestCase name="ibm_format_compat_02"
root="ABC" model="ABC_IBM.dfdl.xsd" description=""
roundTrip="twoPass">
- <tdml:document><![CDATA[a
-]]></tdml:document>
+ <tdml:document>
+ <tdml:documentPart type="text"
replaceDFDLEntities="true"><![CDATA[a%LF;]]></tdml:documentPart>
Review comment:
I'm not going to suggest changing these, but in these short-line cases, This
would also have worked since the character being inserted is a legal XML
character:
`<document>a
</document>`
This has little chance of being line-wrapped. The drawback, is if the
character being inserted is not a legal char like LF, but is something like
NUL, then this won't work, and the longer syntax as used in the code, with the
DFDL entities being used, that would be the only way to express it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
