ltapilot commented on a change in pull request #170: Fixed CLI integration tests so that they run properly on Windows. URL: https://github.com/apache/incubator-daffodil/pull/170#discussion_r251569241
########## File path: daffodil-cli/src/it/scala/org/apache/daffodil/tunables/TestCLITunables2.scala ########## @@ -34,13 +34,13 @@ class TestCLITunables2 { try { // note: 2>&1 is shell-speak for "connect stderr into stdout" - val cmd = String.format("""echo "a,b" | %s parse -s %s -TsuppressSchemaDefinitionWarnings=all 2>&1""", Util.binPath, testSchemaFile) + val cmd = String.format("""echo a,b| %s parse -s %s -TsuppressSchemaDefinitionWarnings=all 2>&1""", Util.binPath, testSchemaFile) Review comment: For the record, I concur with Steve. The 'Util.echoN' function is only intended to cover the difference in 'echo' behavior between Windows and Linux when the stated conditions are met. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services