stevedlawrence commented on a change in pull request #173: Allow implicit conversion of string to HexBinary URL: https://github.com/apache/incubator-daffodil/pull/173#discussion_r251822940
########## File path: daffodil-runtime1/src/main/scala/org/apache/daffodil/dpath/XSHexBinary.scala ########## @@ -90,14 +90,6 @@ case class XSHexBinary(recipe: CompiledDPath, argType: NodeInfo.Kind) val name = "XSHexBinary" Review comment: XSHexBinary mixes in HexBinaryKind, which I think isn't needed anymore? Can that be removed? +1 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
