stevedlawrence commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254681938
########## File path: daffodil-cli/build.sbt ########## @@ -26,10 +31,9 @@ enablePlugins(RpmPlugin) executableScriptName := "daffodil" packageName in Universal := "apache-daffodil-" + version.value + "-incubating-bin" //tarball name - packageName in Linux := executableScriptName.value - packageName in Rpm := "apache-" + executableScriptName.value +packageName in Windows := executableScriptName.value Review comment: executableScriptName.value is current `daffodill` in lowercase. This isn't a big deal, but I'm curious where this is actuall used, considering you set ``name in Windows := "Daffodil"``. That seems correct for windows, it's just not clear to me how ``packageName in Windows`` and ``name in Windows`` differ. Do you know? Can you try changing the values and see what changes if it isn't clear? The other packageNames modify things so they have apache in them. That would probably be a good idea in some cases. For examle, maybe packageName is used in the welcome screen, in which case changing it to ``"Apache Daffodil (incubating) " + version.value`` might make sense, and would be similar to what the above packageNames are set to. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
