ltapilot commented on a change in pull request #178: Created Windows MSI installer package. URL: https://github.com/apache/incubator-daffodil/pull/178#discussion_r254855443
########## File path: daffodil-cli/build.sbt ########## @@ -26,10 +31,9 @@ enablePlugins(RpmPlugin) executableScriptName := "daffodil" packageName in Universal := "apache-daffodil-" + version.value + "-incubating-bin" //tarball name - packageName in Linux := executableScriptName.value - packageName in Rpm := "apache-" + executableScriptName.value +packageName in Windows := executableScriptName.value Review comment: Looks like this causes some odd XML Id fields to be generated. It doesn't create anything that crashes, but the Id fields look really strange when you do this. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
