jadams-tresys commented on a change in pull request #179: Return xs:decimal
when dividing xs:long
URL: https://github.com/apache/incubator-daffodil/pull/179#discussion_r255514531
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_expressions/expressions.tdml
##########
@@ -7184,6 +7185,11 @@
<tdml:infoset><tdml:dfdlInfoset><div21>7.290005321703885E-5</div21></tdml:dfdlInfoset></tdml:infoset>
</tdml:parserTestCase>
+ <tdml:parserTestCase name="div22" root="div22" model="XPathDiv"
description="Section 23 - DFDL Expressions - div"
+ config="cfg_errorOnResultCoercion">
+ <tdml:document></tdml:document>
+
<tdml:infoset><tdml:dfdlInfoset><div22>0.028125</div22></tdml:dfdlInfoset></tdml:infoset>
Review comment:
Just pushed up the tests. Meant to do that last week, but forgot about
adding tests then. I was struggling with getting the unit tests working to
verify the types, so I did what you originally suggested and had tests
expecting incorrect types and then made sure the appropriate error message was
displayed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
