stevedlawrence commented on a change in pull request #184: Added sbt-scoverage
code coverage reporting
URL: https://github.com/apache/incubator-daffodil/pull/184#discussion_r257278806
##########
File path: .travis.yml
##########
@@ -39,3 +39,7 @@ script:
- sbt -J-Xms1g -J-Xmx5g ++$TRAVIS_SCALA_VERSION daffodil-japi/genjavadoc:doc
- sbt -J-Xms1g -J-Xmx5g ++$TRAVIS_SCALA_VERSION daffodil-sapi/doc
- sbt -J-Xms1g -J-Xmx5g ++$TRAVIS_SCALA_VERSION ratCheck
+ - sbt clean coverage test it:test
Review comment:
I think we need to specifc tyhe ``-J`` and ``TRAVIS_SCALA_VERSION`` options
for all sbt commands for things to play nicely with TravisCI. Otherwise we'd
probably run into memory issues and SBT wouldn't use the correct scala version.
This also runs all the tests twice, once above without coverage and once
down here with coverage. That's going to make builds take much longer.
To solve these issues, would it work to add ``coverage`` before the ``test``
and ``it:test`` commands above so all tests run with coverage enabled, and then
add then the coverage report and coverage aggregate down here (include the -J
args and TRACIS_SCALA_VERSION args)?
Also, is the coverageAggregate needed? Looking at the codecov.io/bash
script, it looks like it searches the root directory for all coverage reports,
uploades them all, and then codecov.io merges theresults.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
