mbeckerle commented on a change in pull request #188: Remove extraneous XML
loads for repeating include/imports
URL: https://github.com/apache/incubator-daffodil/pull/188#discussion_r260921060
##########
File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/IIBase.scala
##########
@@ -133,8 +133,8 @@ abstract class IIBase( final override val xml: Node,
xsdArg: XMLSchemaDocument,
* schema file, recursively any of its includes/imports,
* and that all the resulting are validated by the validating loader.
*/
- requiredEvaluations(iiSchemaFile)
- requiredEvaluations(iiSchemaFile.iiXMLSchemaDocument)
+ requiredEvaluations(iiSchemaFileMaybe)
Review comment:
Please add code comment as to why this does the "right thing" - avoids
redundant loading.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
