stevedlawrence opened a new pull request #191: Ensure locale does not effect text numbers and date/times URL: https://github.com/apache/incubator-daffodil/pull/191 There were two main issues where locale could have an effect: - We previously only set grouping separator or decimal separator if the text number pattern contained the grouping or decimal character. However, even if the pattern does not contain a grouping/decimal character, the value from the locale can still have an effect if the other does exist. So, if either exists in the pattern, we need to set them both to ensure that the defaults from the locale do not affect the result. - When we parse an infoset string, that creates a new Calendar with some internal values specific to the locale. When we unparse that Calendar those locale specific values can have an effect on the result. To avoid this, copy the date/time values from the new Calendar into the Calendar that was created with DFDL properties, ensuring the locale does not effect the result. The remaining issues were related to unit tests that didn't properly set all the decimal format symbols, causing locale had an affect. DAFFODIL-2074
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
