mbeckerle commented on a change in pull request #195: Changes to support
building in IntelliJ
URL: https://github.com/apache/incubator-daffodil/pull/195#discussion_r265115543
##########
File path:
daffodil-test-ibm1/src/test/scala/org/apache/daffodil/TresysTests.scala
##########
@@ -158,9 +175,35 @@ class TresysTests {
@Test def test_AZ000() { runnerAZ.runOneTest("AZ000") } // escape schemes
- // Jira DFDL-1392
- // @Test def test_BA000() { runnerBA.runOneTest("BA000") } // escape
schemes and delimiters
+ // Jira DFDL-1392 - Issue with escapeEscape character that is first and
precedes an escape-block start.
+ // Is being removed, but should be preserved as it does not precede an
escape character, nor an escape block end.
+ //@Test def test_BA000() { runnerBA.runOneTest("BA000") } // escape schemes
and delimiters
+ //@Test def test_BB000() { runnerBB.runOneTest("BB000") } // occursCountKind
stopValue
+
+ //DFDL-1010
+ //@Test def test_BE000() { runnerBE.runOneTest("BE000") } // unordered
sequences
+ //@Test def test_BE001() { runnerBE.runOneTest("BE001") }
+
+ //DFDL-1010
+ //@Test def test_BF000() { runnerBF1.runOneTest("BF000") } // unordered
sequences
+ //@Test def test_BF001() { runnerBF1.runOneTest("BF001") }
+
+ //@Test def test_BG000() { runnerBG.runOneTest("BG000") } // needs text
numbers: advanced properties (DFDL-452)
+
+ //@Test def test_BC000() { runnerBC.runOneTest("BC000") } // text boolean
type
Review comment:
Some of these tests "should" work e.g., this one says in comment it needs
text boolean type, which we have now.
There's no ticket associated with it (DFDL-XXX or DAFFODIL-XXX) so this will
never get revisited..... Suggest we add a structured comment we can search for
e.g., "// NO JIRA TICKET" so that we can easily take a pass and find these.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services