jadams-tresys commented on a change in pull request #196: Use setScale() not 
round() when rounding BigDecimals
URL: https://github.com/apache/incubator-daffodil/pull/196#discussion_r266061115
 
 

 ##########
 File path: 
daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_functions/Functions.tdml
 ##########
 @@ -4324,6 +4324,8 @@
       </xs:complexType>
     </xs:element>
     
+    <xs:element name="ceil08" type="xs:decimal" dfdl:inputValueCalc="{ 
fn:ceiling(xs:decimal(0.125)) }"/>
 
 Review comment:
   I'll add the test, but I think that it should be OK since setScale actually 
returns a copy with the scale set to the new value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to