stevedlawrence commented on a change in pull request #202: Daffodil 2095
commented out tests
URL: https://github.com/apache/incubator-daffodil/pull/202#discussion_r270376680
##########
File path:
daffodil-test/src/test/resources/org/apache/daffodil/section23/dfdl_expressions/expressions.tdml
##########
@@ -3252,14 +3252,9 @@
model="newRegex" description="Section - - DFDL-R">
<tdml:document>45someletters</tdml:document>
- <tdml:infoset>
- <tdml:dfdlInfoset>
- <s1>
- <e1>45</e1>
- <extra>someletters</extra>
- </s1>
- </tdml:dfdlInfoset>
- </tdml:infoset>
+ <tdml:errors>
+ <tdml:error>This expression is not supported in the current option
setting</tdml:error>
Review comment:
This is kindof a weird error message, I"m not even sure what it means but it
looks like the issue is the test is using a 4-byte unicode character in the
regular expression? Is there extra information in the error message that the
test just isn't looking for that makes the problem more clear? If not, it might
be worth opening a bug to make this error message better, to at least make it
clear something is wrong with the regular expression as opposed to a DFDL
expression.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
