mbeckerle commented on a change in pull request #201: Fix bug in handling parse
errors
URL: https://github.com/apache/incubator-daffodil/pull/201#discussion_r276512083
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/ProcessingError.scala
##########
@@ -47,7 +47,7 @@ abstract class ProcessingError protected (
* looks like the same as other parse errors to tests that search for the
* "Parse Error" string.
*/
- def toParseError = new ParseError(schemaContext, dataContext, Maybe(this),
maybeFormatString, args: _*)
+ def toParseError = new ParseError(schemaContext, dataContext, maybeCause,
maybeFormatString, args: _*)
Review comment:
Changing this to maybeCause isn't correct.
'this' object itself becomes the cause of the new ParseError. You are
jumping ahead one in the chain of nested exceptions by using maybeCause here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
