jadams-tresys commented on a change in pull request #208: Output empty elements
with self closing tags
URL: https://github.com/apache/incubator-daffodil/pull/208#discussion_r276640277
##########
File path:
daffodil-runtime1/src/main/scala/org/apache/daffodil/infoset/XMLTextInfosetOutputter.scala
##########
@@ -97,19 +101,24 @@ class XMLTextInfosetOutputter(writer: java.io.Writer,
pretty: Boolean = true)
override def startComplex(complex: DIComplex): Boolean = {
val name = getTagName(complex)
if (pretty) outputIndentation(writer)
- outputStartTag(complex, name)
+ outputStartTag(complex, name, complex.children.isEmpty)
Review comment:
I've updated this with the suggested hasVisibleChildren as a boolean that
gets set to true as soon as a visible child is added to the complex element
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
