stevedlawrence commented on a change in pull request #207: Added support for enumerations and TypeValueCalc URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r278204295
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/AnnotatedSchemaComponent.scala ########## @@ -38,11 +38,17 @@ import org.apache.daffodil.api.WarnID * property resolution. * * The only objects that should resolve properties are - * ElementRef, Root, LocalElementDecl, Sequence, Choice, SequenceRef, ChoiceRef + * ElementRef, Root, LocalElementDecl, Sequence, Choice, SequenceRef, ChoiceRef, + * EnumerationFactory, SimpleTypeDefFactory, * - * These are all the "real" terms. Everything else is just contributing + * All "real" terms are able to resolve properties. Most other objects just contribute * properties to the mix, but they are not points where properties are * used to generate processors. + * + * EnumerationFactory and SimpleTypeDefFactory are the oddballs out. In addition to being used to generate processors, + * these classes our also used to generate abstract TypeCalculators, which are not nessasarily attached to any particular element, + * nor used to generate any processor (for instance, there may be a globalSimpleType whose only purpose is to define a TypeCalculator for + * use in DPath expressions) Review comment: Can you wrap comments to a smaller length to make reviews easier? GitHub only show's around 100 or so characters ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
