stevedlawrence commented on a change in pull request #207: Added support for 
enumerations and TypeValueCalc
URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279780900
 
 

 ##########
 File path: 
daffodil-runtime1/src/main/scala/org/apache/daffodil/processors/parsers/ExpressionEvaluatingParsers.scala
 ##########
 @@ -67,6 +83,82 @@ class IVCParser(expr: CompiledExpression[AnyRef], e: 
ElementRuntimeData)
     }
 }
 
+/*
+ * Run a parser for an element that does not occur in the infoset
+ * Prior to running, a temporary element (of the type expected by the parser) 
will be created in the infoset,
+ * After running, the infoset will be reverted to its original state, but any 
other side effect of parsing will remain
+ *
+ * Additionally, the dataValue of the element the parser parsed will be 
returned
+ */
+trait withDetachedParser {
 
 Review comment:
   Captial trait name. Also, should this be WithQuasiParser? Detached was 
changed to Quasi in the grammar, should probably be changed here for 
consistency.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to