stevedlawrence commented on a change in pull request #207: Added support for
enumerations and TypeValueCalc
URL: https://github.com/apache/incubator-daffodil/pull/207#discussion_r279754764
##########
File path:
daffodil-core/src/main/scala/org/apache/daffodil/grammar/ElementBaseGrammarMixin.scala
##########
@@ -1485,13 +1492,17 @@ trait ElementBaseGrammarMixin
private lazy val scalarDefaultablePhysical =
prod("scalarDefaultablePhysical") {
- val elem = new ElementCombinator(this, elementLeftFraming ~ dfdlScopeBegin,
- withDelimiterStack {
- withEscapeScheme {
- scalarDefaultableSimpleContent || scalarComplexContent
- }
- },
- elementRightFraming ~ dfdlScopeEnd)
+ val elem = if (hasRepType) {
+ new ElementCombinator(this, dfdlScopeBegin,
scalarDefaultableSimpleContent, dfdlScopeEnd, new TypeValueCalc(this))
Review comment:
This differs from below in that there is no framing or delimiter/escape
schema stuff. Does this mean that if an element has a rep type, then things
like alignment, initiators, terminators, etc. are ignored? Or does that just
end up in the repTypeParser?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
