stevedlawrence opened a new pull request #219: Ensure InputStreams created by includes/imports are closed URL: https://github.com/apache/incubator-daffodil/pull/219 - When we open a stream from a DaffodilInputSource, make sure we close the streams when we are done with them - In our custom LSInput implementation (renamed to InputStreamLSInput), we provided an InputStream *and* an implementation of getStringData(). However, when getStringData() returns non-null, Xerces ignores the fact that an InputStream is provided and so Xerces never closes it. If we instead make getStringData() return null, Xerces will then use the InputStream and will close it once the stream is parsed. The added benefit here is that Xerces *should* be able to look at the preamble and determine XML encoding, which we previously did not do with our getStringData implementation. These changes should allow Daffodil to support a much larger number of includes/imports without hitting "Too many open files" errors. DAFFODIL-2130
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
