mbeckerle commented on a change in pull request #214: Sequences and Separators
Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285728285
##########
File path:
daffodil-propgen/src/main/scala/org/apache/daffodil/propGen/PropertyGenerator.scala
##########
@@ -36,16 +36,16 @@ class PropertyGenerator(arg: Node) {
val dfdlSchema = arg
- val excludedTypes = List("TextNumberBase", "AlignmentType", "FillByteType",
"BinaryBooleanTrueRepType", "BinaryBooleanFalseRepType",
+ val excludedTypes = List("Property", "EmptyElementPolicy", "TextNumberBase",
"AlignmentType", "FillByteType", "BinaryBooleanTrueRepType",
"BinaryBooleanFalseRepType",
Review comment:
Yes. There were a few things about propgen that were really inexact and
generating unused and spurious code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
