mbeckerle commented on a change in pull request #214: Sequences and Separators Refactoring and Rewrite URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r285797819
########## File path: daffodil-core/src/main/scala/org/apache/daffodil/dsom/ChoiceGroup.scala ########## @@ -94,8 +94,7 @@ trait ChoiceDefMixin } } -abstract class ChoiceTermBase( - final override val xml: Node, +abstract class ChoiceTermBase(final override val xml: Node, Review comment: New Info: so the scalariform parameter of interest is actually not the one mentioned above. It is firstParameterOnNewline which defaults to "Force" which puts a new line before the first parameter every time, even if all the args would just fit on one line. There is also Prevent, which is first arg stays on the line, and Preserve, which doesn't futz with them. However, eclipse just lets you check a box or not, so you have Force, or Preserve as the settings I believe. Turns out in eclipse, if you choose "reset to defaults" on the scala formatter, it checks the box for this. I was previously under the impression that default settings had no boxes checked, but that is not the case. So I will reset these to the default, and re-save the files I have been editing to reapply the first parameter on a new line. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
