jadams-tresys commented on a change in pull request #214: Sequences and
Separators Refactoring and Rewrite
URL: https://github.com/apache/incubator-daffodil/pull/214#discussion_r286546668
##########
File path:
daffodil-runtime1-unparser/src/main/scala/org/apache/daffodil/processors/unparsers/ZeroLengthDetector.scala
##########
@@ -97,7 +187,7 @@ sealed trait HexBinaryZeroLengthMixin { self:
ZeroLengthDetector =>
else {
diElement match {
case st: DISimple => {
- Assert.invariant(st.hasValue)
+ // Assert.invariant(st.hasValue) - Wrong. This might not have
value if defaultable.
Review comment:
Remove?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services